v3 rewrite - #22
Closed
Sammster10 wants to merge 75 commits into
Closed
Conversation
This was
linked to
issues
Oct 7, 2025
Closed
Closed
- previously each insert context only knew about itself. this lead to statements being generated to satisfy dependencies. this is fine, however in the context of a batch, the statement may already be present. this change makes every statement aware of every other statement within the batch
all data classes must be loaded, then #finishLoading() should be called. this is what syncs the data from the source rather than doing multiple syncs
this is not needed and introduced lots of issues
…enient, it can be misleading. For example, do i update the values in the referenced table, or the referring table?
…es rather than the linking column values
…transaction has been committed. this also means that update handlers are called instantly, and no longer require being submitted to another thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation behind this rewrite is simple. 1. static-data needs to be more flexible. 2. Delegating a lot of the heavy lifting to H2 makes this project much easier to maintain.
While #20 is not implemented directly, with the query builder we can support more flexible, map-like queries. i.e
WHERE user.fav_color = ?. key being fav_color, value being user.